feat: forward reqwest's rustls-no-provider feature#556
Merged
Conversation
Exposes reqwest 0.13's `rustls-no-provider` feature so consumers can opt out of the bundled `aws-lc-rs` crypto provider and install their own (e.g. `ring`).
Adds a `tls-features` job that builds each TLS variant against chat-completion (`rustls`, `rustls-no-provider`, `native-tls`, `native-tls-vendored`) and asserts via `cargo tree` that: - `rustls-no-provider` does NOT pull in `aws-lc-rs` (the regression we want to protect against). - `rustls` DOES pull in `aws-lc-rs` (sanity check that the assertion above is meaningful).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #547
This adds a new feature
rustls-no-providerwhich will forward to reqwest. This allows users to provide their own rustls crypto provider.This contains additions to the CI jobs to prevent regressions in the future.